Messages in this thread Patch in this message | | | From | David Kozub <> | Subject | [PATCH 07/16] block: sed-opal: unify error handling of responses | Date | Thu, 14 Feb 2019 01:15:59 +0100 |
| |
response_get_{string,u64} include error handling for argument resp being NULL but response_get_token does not handle this.
Make all three of response_get_{string,u64,token} handle NULL resp in the same way.
Co-authored-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de> Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de> Reviewed-by: Scott Bauer <sbauer@plzdonthack.me> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Jon Derrick <jonathan.derrick@intel.com> --- block/sed-opal.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/block/sed-opal.c b/block/sed-opal.c index 0348fb896a5d..3f368b14efd9 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -696,6 +696,11 @@ static const struct opal_resp_tok *response_get_token( { const struct opal_resp_tok *tok; + if (!resp) { + pr_debug("Response is NULL\n"); + return ERR_PTR(-EINVAL); + } + if (n >= resp->num) { pr_debug("Token number doesn't exist: %d, resp: %d\n", n, resp->num); -- 2.20.1
| |