Messages in this thread | | | From | "Derrick, Jonathan" <> | Subject | Re: [PATCH 11/16] block: sed-opal: add token for OPAL_LIFECYCLE | Date | Thu, 28 Mar 2019 15:43:53 +0000 |
| |
Acked-by: Jon Derrick <jonathan.derrick@intel.com>
On Thu, 2019-02-14 at 01:16 +0100, David Kozub wrote: > Define OPAL_LIFECYCLE token and use it instead of literals in > get_lsp_lifecycle. > > Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz> > --- > block/opal_proto.h | 2 ++ > block/sed-opal.c | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/block/opal_proto.h b/block/opal_proto.h > index e20be8258854..b6e352cfe982 100644 > --- a/block/opal_proto.h > +++ b/block/opal_proto.h > @@ -170,6 +170,8 @@ enum opal_token { > OPAL_READLOCKED = 0x07, > OPAL_WRITELOCKED = 0x08, > OPAL_ACTIVEKEY = 0x0A, > + /* lockingsp table */ > + OPAL_LIFECYCLE = 0x06, > /* locking info table */ > OPAL_MAXRANGES = 0x04, > /* mbr control */ > diff --git a/block/sed-opal.c b/block/sed-opal.c > index ad66d1dc725a..7f02e50e2bce 100644 > --- a/block/sed-opal.c > +++ b/block/sed-opal.c > @@ -1786,12 +1786,12 @@ static int get_lsp_lifecycle(struct opal_dev > *dev, void *data) > > add_token_u8(&err, dev, OPAL_STARTNAME); > add_token_u8(&err, dev, 3); /* Start Column */ > - add_token_u8(&err, dev, 6); /* Lifecycle Column */ > + add_token_u8(&err, dev, OPAL_LIFECYCLE); > add_token_u8(&err, dev, OPAL_ENDNAME); > > add_token_u8(&err, dev, OPAL_STARTNAME); > add_token_u8(&err, dev, 4); /* End Column */ > - add_token_u8(&err, dev, 6); /* Lifecycle Column */ > + add_token_u8(&err, dev, OPAL_LIFECYCLE); > add_token_u8(&err, dev, OPAL_ENDNAME); > > add_token_u8(&err, dev, OPAL_ENDLIST); [unhandled content-type:application/x-pkcs7-signature] | |