Messages in this thread | | | From | Rasmus Villemoes <> | Subject | fsl,p2020-esdhc sdhci quirks | Date | Tue, 3 Dec 2019 11:15:37 +0100 |
| |
Hi
Commits
05cb6b2a66fa - mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support a46e42712596 - mmc: sdhci-of-esdhc: add erratum eSDHC5 support
seem a bit odd, in that they set bits from the SDHCI_* namespace in the ->quirks2 member:
host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST; host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
These are bits 10 and 12, so they are also known as SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD and SDHCI_QUIRK2_TUNING_WORK_AROUND. So if the fixes are correct, one should use those names on the right-hand side, but it seems just as likely (I can't figure that out from the commit messages) that the left-hand sides should have been host->quirks ?
Rasmus
| |