Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Tue, 3 Dec 2019 17:26:20 +0800 | Subject | Re: [PATCH 1/2] x86_64_defconfig: Normalize x86_64 defconfig |
| |
On Tue, 3 Dec 2019 at 17:05, Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Hi Krzysztof, > > Many thanks for your quick answer. > > On 3/12/19 3:15, Krzysztof Kozlowski wrote: > > On Tue, 3 Dec 2019 at 05:18, Enric Balletbo i Serra > > <enric.balletbo@collabora.com> wrote: > >> > >> make savedefconfig result in some difference, lets normalize the > >> defconfig > >> > > > > No, for two reasons: > > 1. If running savedefconfig at all, split reordering items from > > removal of non needed options. This way we can see exactly what is > > being removed. This patch moves things around so it is not possible to > > understand what exactly you're doing here... > > Ok, makes sense, I can do it, but if you don't really care of having the > defconfig sync with the savedefconfig output for the below reasons or others, > that's fine with me. > > The reason I send the patch is because I think that, at least on some arm > defconfigs, they try to have the defconfig sync with the savedefconfig output, > the idea is to try to make patching the file easier, but I know this is usually > a pain.
Till I saw DEBUG_FS removal and Steven's answer, I was all in in such patches from time to time. However now I think it's risky and instead manual cleanup of non-visible symbols is better.
Best regards, Krzysztof
| |