Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Tue, 3 Dec 2019 10:15:56 +0800 | Subject | Re: [PATCH 1/2] x86_64_defconfig: Normalize x86_64 defconfig |
| |
On Tue, 3 Dec 2019 at 05:18, Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > make savedefconfig result in some difference, lets normalize the > defconfig >
No, for two reasons: 1. If running savedefconfig at all, split reordering items from removal of non needed options. This way we can see exactly what is being removed. This patch moves things around so it is not possible to understand what exactly you're doing here... 2. Do not remove options just because other select them in a blind way - via savedefconfig. As it turns out, some developers have different view on dependencies and they expect that defconfig *explicitly* pulls out necessary functions. IOW, they can safely remove any visible symbol dependency assuming that defconfigs are selecting this removed symbol explicitly. See: https://patchwork.kernel.org/patch/11260361/ (commit which removed DEBUG_FS - Marek Szyprowski will bring it back, I think, and Steven Rostedt answer)
Best regards, Krzysztof
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > arch/x86/configs/x86_64_defconfig | 90 +++++++++++-------------------- > 1 file changed, 30 insertions(+), 60 deletions(-) >
| |