Messages in this thread | | | Date | Sat, 14 Dec 2019 20:33:37 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH v2 1/3] net: macb: fix for fixed-link mode |
| |
On Fri, 13 Dec 2019 09:41:01 +0000, Milind Parab wrote: > This patch fix the issue with fixed link. With fixed-link > device opening fails due to macb_phylink_connect not > handling fixed-link mode, in which case no MAC-PHY connection > is needed and phylink_connect return success (0), however > in current driver attempt is made to search and connect to > PHY even for fixed-link. > > Signed-off-by: Milind Parab <mparab@cadence.com>
We'll wait to give a chance for Russell, Andrew and others to review, but this patch looks like a fix and the other ones look like features. You should post the fix separately so it's included in Linus'es tree ASAP (mark the patch with [PATCH net]), and the rest of the patches can wait for the next merge window (mark [PATCH net-next]). Fixes should also have an appropriate Fixes tag pointing at the first commit where the bug was present.
| |