Messages in this thread | | | Date | Wed, 11 Dec 2019 15:18:56 +0000 | From | Daniel Thompson <> | Subject | Re: [PATCH] sh: kgdb: Mark expected switch fall-throughs |
| |
On Tue, Dec 10, 2019 at 05:39:00PM +0900, Kuninori Morimoto wrote: > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following error: > > LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': > LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] > if (kgdb_hex2long(&ptr, &addr)) > ^ > LINUX/arch/sh/kernel/kgdb.c:269:2: note: here > case 'D': > ^~~~ > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > arch/sh/kernel/kgdb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c > index 6d61f8c..0d5f3c9 100644 > --- a/arch/sh/kernel/kgdb.c > +++ b/arch/sh/kernel/kgdb.c > @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, > ptr = &remcomInBuffer[1]; > if (kgdb_hex2long(&ptr, &addr)) > linux_regs->pc = addr; > + /* fallthrough */
Since v5.5-rc1 there is the fallthrough pseudo keyword to document these cases: https://elixir.bootlin.com/linux/v5.5-rc1/source/Documentation/process/coding-style.rst#L59
Daniel.
> case 'D': > case 'k': > atomic_set(&kgdb_cpu_doing_single_step, -1); > -- > 2.7.4 >
| |