Messages in this thread | | | Subject | Re: [PATCH] sh: kgdb: Mark expected switch fall-throughs | From | Christophe Leroy <> | Date | Tue, 10 Dec 2019 08:47:56 +0000 |
| |
On 12/10/2019 08:39 AM, Kuninori Morimoto wrote: > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following error: > > LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': > LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] > if (kgdb_hex2long(&ptr, &addr)) > ^ > LINUX/arch/sh/kernel/kgdb.c:269:2: note: here > case 'D': > ^~~~ > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
I guess you should also add:
Fixes: ab6e570ba33d ("sh: Generic kgdb stub support.") Cc: stable@vger.kernel.org
Christophe
| |