Messages in this thread | | | Date | Tue, 10 Dec 2019 17:37:01 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: max77650: add of_match table |
| |
On Tue, Dec 10, 2019 at 05:53:11PM +0100, Bartosz Golaszewski wrote: > wt., 10 gru 2019 o 14:21 Mark Brown <broonie@kernel.org> napisał(a): > > On Tue, Dec 10, 2019 at 02:10:15PM +0100, Bartosz Golaszewski wrote: > > > wt., 10 gru 2019 o 14:02 Mark Brown <broonie@kernel.org> napisał(a):
> > > MODULE_ALIAS("platform:max77650-regulator");
> > Huh, that should work... I wonder if adding a compatible to the DT has > > messed it up, does it work without the compatible in the .dts (and with > > the of_compatible removed from the MFD driver I guess)?
> It does work when removing the compatible strings.
Ah, that explains it.
> > Yeah. Though it may be too late, shame I didn't catch this when it was > > merged :(
> Yeah, I didn't know any better too.
> Rob: the bindings for this were released some time ago and they define > compatible strings for MFD sub-nodes, but using compatible strings for > sub-nodes is apparently incorrect and the drivers don't support it > either. Can we remove them from the bindings?
I think at this point it's better to just keep compatibility rather than disrupt anything, I'll go ahead and apply your patch. [unhandled content-type:application/pgp-signature] | |