Messages in this thread | | | Date | Tue, 10 Dec 2019 13:21:36 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: max77650: add of_match table |
| |
On Tue, Dec 10, 2019 at 02:10:15PM +0100, Bartosz Golaszewski wrote: > wt., 10 gru 2019 o 14:02 Mark Brown <broonie@kernel.org> napisał(a):
> > This seems to work fine for other drivers and the platform bus has to be > > usable on systems that don't use DT so that doesn't sound right. Which > > MODULE_ALIAS() are you using exactly?
> MODULE_ALIAS("platform:max77650-regulator");
Huh, that should work... I wonder if adding a compatible to the DT has messed it up, does it work without the compatible in the .dts (and with the of_compatible removed from the MFD driver I guess)?
> > > Besides: the DT bindings define the compatible for sub-nodes already. > > > We should probably conform to that.
> > I would say that's a mistake and should be fixed, this particular way of > > loading the regulators is a Linux implementation detail.
> Fixed by removing this from the bindings?
Yeah. Though it may be too late, shame I didn't catch this when it was merged :( [unhandled content-type:application/pgp-signature] | |