Messages in this thread | | | Subject | Re: [PATCH v2 2/4] Bluetooth: btbcm: Support pcm configuration | From | Marcel Holtmann <> | Date | Fri, 8 Nov 2019 07:11:24 +0100 |
| |
Hi Abhishek,
> Add BCM vendor specific commands to configure PCM.
please be a bit more descriptive and you can also add the command decoding from btmon here if you like.
> > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> > --- > > Changes in v2: None > > drivers/bluetooth/btbcm.c | 35 +++++++++++++++++++++++++++++++++++ > drivers/bluetooth/btbcm.h | 10 ++++++++++ > 2 files changed, 45 insertions(+) > > diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c > index 2d2e6d862068..f052518f7b0c 100644 > --- a/drivers/bluetooth/btbcm.c > +++ b/drivers/bluetooth/btbcm.c > @@ -105,6 +105,41 @@ int btbcm_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr) > } > EXPORT_SYMBOL_GPL(btbcm_set_bdaddr); > > +int btbcm_set_pcm_params(struct hci_dev *hdev, > + const struct bcm_set_pcm_int_params *int_params, > + const struct bcm_set_pcm_format_params *format_params) > +{ > + struct sk_buff *skb; > + int err; > + > + if (int_params) { > + skb = __hci_cmd_sync(hdev, 0xfc1c, 5, int_params, > + HCI_INIT_TIMEOUT); > + if (IS_ERR(skb)) { > + err = PTR_ERR(skb); > + bt_dev_err(hdev, "BCM: Set PCM int params failed (%d)", > + err); > + return err; > + } > + kfree_skb(skb); > + }
Actually lets do btbcm_set_pcm_int_params and focus on the ones you are using right now.
Regards
Marcel
| |