Messages in this thread | | | From | <> | Subject | Re: [PATCH v4 12/20] mtd: spi-nor: Print debug message when the read back test fails | Date | Wed, 6 Nov 2019 07:24:31 +0000 |
| |
On 11/05/2019 02:37 PM, Vignesh Raghavendra wrote: > On 02/11/19 4:53 PM, Tudor.Ambarus@microchip.com wrote: >> From: Tudor Ambarus <tudor.ambarus@microchip.com> >> >> Demystify where the EIO error occurs. >> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> >> --- > I think this is a small enough change that can be squashed into previous > patch itself >
I made separate patches because this is a separate logical change. The previous patch extends the check on all bits of the Status Register, while this one prints a debug message in case of EIO. Thus I tried to have a single logical change contained in a single patch. I'm clearly no expert in this (Boris asked me in v3 to split patches because I did too many things in one patch :) ), so I would keep this as is, but if you still feel that it should be squashed, then I'll do it. Please let me know.
| |