| Subject | Re: [PATCH v4 12/20] mtd: spi-nor: Print debug message when the read back test fails | From | Vignesh Raghavendra <> | Date | Tue, 5 Nov 2019 18:07:54 +0530 |
| |
On 02/11/19 4:53 PM, Tudor.Ambarus@microchip.com wrote: > From: Tudor Ambarus <tudor.ambarus@microchip.com> > > Demystify where the EIO error occurs. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > ---
I think this is a small enough change that can be squashed into previous patch itself
> drivers/mtd/spi-nor/spi-nor.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 8f5e9833081b..725dab241271 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -974,7 +974,12 @@ static int spi_nor_write_sr_and_check(struct spi_nor *nor, u8 status_new) > if (ret) > return ret; > > - return (nor->bouncebuf[0] != status_new) ? -EIO : 0; > + if (nor->bouncebuf[0] != status_new) { > + dev_dbg(nor->dev, "SR: read back test failed\n"); > + return -EIO; > + } > + > + return 0; > } > > /** >
-- Regards Vignesh
|