lkml.org 
[lkml]   [2019]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 10/10] ocxl: Conditionally bind SCM devices to the generic OCXL driver
From
Date
On 25/10/19 3:47 pm, Alastair D'Silva wrote:
> From: Alastair D'Silva <alastair@d-silva.org>
>
> This patch allows the user to bind OpenCAPI SCM devices to the generic OCXL
> driver.
>
> Signed-off-by: Alastair D'Silva <alastair@d-silva.org>

Agree that this needs more explanation - both in the commit and the
Kconfig help.

> diff --git a/drivers/misc/ocxl/pci.c b/drivers/misc/ocxl/pci.c
> index cb920aa88d3a..7137055c1883 100644
> --- a/drivers/misc/ocxl/pci.c
> +++ b/drivers/misc/ocxl/pci.c
> @@ -10,6 +10,9 @@
> */
> static const struct pci_device_id ocxl_pci_tbl[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x062B), },
> +#ifdef CONFIG_OCXL_SCM_GENERIC
> + { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0625), },
> +#endif
> { }
> };
> MODULE_DEVICE_TABLE(pci, ocxl_pci_tbl);
>

If there's no way to use the ID table from ocxl-scm directly, there
should at least be a comment both here and in the ocxl-scm device ID
table mentioning that you need to keep these in sync.

--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited

\
 
 \ /
  Last update: 2019-11-06 04:48    [W:0.510 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site