lkml.org 
[lkml]   [2019]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 10/10] ocxl: Conditionally bind SCM devices to the generic OCXL driver
    From
    Date
    On Thu, 2019-11-07 at 19:08 +0100, Frederic Barrat wrote:
    >
    > Le 25/10/2019 à 06:47, Alastair D'Silva a écrit :
    > > From: Alastair D'Silva <alastair@d-silva.org>
    > >
    > > This patch allows the user to bind OpenCAPI SCM devices to the
    > > generic OCXL
    > > driver.
    > >
    > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
    > > ---
    >
    > I'm wondering if we should upstream this. Is it of any use outside
    > of
    > some serious debug session for a developer?
    > Also we would now have 2 drivers picking up the same device ID,
    > since
    > the SCM driver is always registering for that ID, irrespective of
    > CONFIG_OCXL_SCM_GENERIC
    >
    > Fred
    >

    I think I'll drop this patch. It's easy enough to maintain out-of-tree
    for our in-house SCM hardware engineers.

    >
    > > drivers/misc/ocxl/Kconfig | 7 +++++++
    > > drivers/misc/ocxl/pci.c | 3 +++
    > > 2 files changed, 10 insertions(+)
    > >
    > > diff --git a/drivers/misc/ocxl/Kconfig b/drivers/misc/ocxl/Kconfig
    > > index 1916fa65f2f2..8a683715c97c 100644
    > > --- a/drivers/misc/ocxl/Kconfig
    > > +++ b/drivers/misc/ocxl/Kconfig
    > > @@ -29,3 +29,10 @@ config OCXL
    > > dedicated OpenCAPI link, and don't follow the same protocol.
    > >
    > > If unsure, say N.
    > > +
    > > +config OCXL_SCM_GENERIC
    > > + bool "Treat OpenCAPI Storage Class Memory as a generic OpenCAPI
    > > device"
    > > + default n
    > > + help
    > > + Select this option to treat OpenCAPI Storage Class Memory
    > > + devices an generic OpenCAPI devices.
    > > diff --git a/drivers/misc/ocxl/pci.c b/drivers/misc/ocxl/pci.c
    > > index cb920aa88d3a..7137055c1883 100644
    > > --- a/drivers/misc/ocxl/pci.c
    > > +++ b/drivers/misc/ocxl/pci.c
    > > @@ -10,6 +10,9 @@
    > > */
    > > static const struct pci_device_id ocxl_pci_tbl[] = {
    > > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x062B), },
    > > +#ifdef CONFIG_OCXL_SCM_GENERIC
    > > + { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0625), },
    > > +#endif
    > > { }
    > > };
    > > MODULE_DEVICE_TABLE(pci, ocxl_pci_tbl);
    > >
    --
    Alastair D'Silva
    Open Source Developer
    Linux Technology Centre, IBM Australia
    mob: 0423 762 819

    \
     
     \ /
      Last update: 2019-11-08 01:38    [W:3.362 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site