Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 29 Nov 2019 09:29:16 +0100 | Subject | Re: [PATCH v2 3/5] regulator: da9062: add voltage selection gpio support |
| |
On Wed, Nov 27, 2019 at 2:59 PM Marco Felsch <m.felsch@pengutronix.de> wrote:
> The DA9062/1 devices can switch their regulator voltages between > voltage-A (active) and voltage-B (suspend) settings. Switching the > voltages can be controlled by ther internal state-machine or by a gpio > input signal and can be configured for each individual regulator. This > commit adds the gpio-based voltage switching support. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > Changelog: > > v2: > - use new public api gpiod_to_offset()
OK this is better in my opinion, at least it is a lesser evil than the hacks I've seen.
> + struct reg_field vsel_gpi;
Again add some comments to the code describing what this is about please. A general purpose input that can be configured such that it is not a general purpose input anymore, but instead looped back internally to control a voltage on the DA9062.
Part of me wonder if these lines are really "general purpose" but I suppose software could use them.
Yours, Linus Walleij
| |