Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 29 Nov 2019 11:19:14 +0100 | Subject | Re: [PATCH v2 1/5] gpio: add support to get local gpio number |
| |
On Fri, Nov 29, 2019 at 11:15 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
> > What about renaming gpio_chip_hwgpio() everywhere > > to gpiod_to_offet(), remove it from drivers/gpio/gpiolib.h > > and export it in <linux/gpio/consumer.h> instead? > > That's also possible but then we have to include the consumer.h header > within the gpiolib.c and this seems to be wrong. But since I'm not the > maintainer it is up to you and Bart. Both ways are possible,
What about following the pattern by the clk subsystem and create <linux/gpio/private.h> and put it there?
It should be an indication to people to not use these features lightly. We can decorate the header file with some warnings.
Yours, Linus Walleij
| |