Messages in this thread | | | Date | Fri, 15 Nov 2019 16:26:41 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] HID: rmi: Check that the RMI_STARTED bit is set before unregistering the RMI transport device |
| |
On Wed, 23 Oct 2019, Andrew Duggan wrote:
> In the event that the RMI device is unreachable, the calls to > rmi_set_mode() or rmi_set_page() will fail before registering the RMI > transport device. When the device is removed, rmi_remove() will call > rmi_unregister_transport_device() which will attempt to access the > rmi_dev pointer which was not set. This patch adds a check of the > RMI_STARTED bit before calling rmi_unregister_transport_device(). > The RMI_STARTED bit is only set after rmi_register_transport_device() > completes successfully. A subsequent patch in the RMI core will add > checks to validate the pointers before accessing them.
Andrew,
my mailbox doesn't seem to have that 'subsequent patch' ... was it ever sent and I missed it? If so, could you please resend it?
Thanks,
-- Jiri Kosina SUSE Labs
| |