Messages in this thread | | | Date | Mon, 28 Oct 2019 21:19:47 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: synaptics-rmi4 - validate that the rmi_dev pointer is set before dereferencing it |
| |
Hi Andrew,
On Wed, Oct 23, 2019 at 01:24:05AM +0000, Andrew Duggan wrote: > A bug in hid-rmi was causing rmi_unregister_transport_device() to be > called even if the call to rmi_register_transport_device() failed to > allocate the rmi device. A patch has been submitted to fix the issue in > hid-rmi. This patch will ensure that should a simialr situation > occur then the rmi driver will not dereference a NULL pointer.
This looks like "garbage in, garbage out" problem where we should not be calling unregister in the first place. I'd rather not apply this.
Thanks.
-- Dmitry
| |