Messages in this thread | | | From | Miguel Ojeda <> | Date | Sat, 5 Oct 2019 19:31:30 +0200 | Subject | Re: [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways |
| |
Hi Joe,
On Sat, Oct 5, 2019 at 6:47 PM Joe Perches <joe@perches.com> wrote: > > diff --git a/scripts/cvt_style.pl b/scripts/cvt_style.pl > new file mode 100755 > index 000000000000..fcbda0b1c67a > --- /dev/null > +++ b/scripts/cvt_style.pl > @@ -0,0 +1,808 @@ > +#!/usr/bin/perl -w
Nit: #!/usr/bin/env perl instead?
> + > +# Change some style elements of a source file > +# An imperfect source code formatter. > +# Might make trivial patches a bit easier. > +# > +# usage: perl scripts/cvt_kernel_style.pl <files> > +# > +# Licensed under the terms of the GNU GPL License version 2
Nit: use # SPDX-License-Identifier: GPL-2.0-only instead
As for the commit itself: while I am sure this tool is very useful (and certainly you put a *lot* of effort into this tool), I don't see how it is related to the fallthrough remapping (at least the non-fallthrough parts).
Also, we should consider whether we want more tools like this now or simply put the efforts into moving to clang-format.
Cheers, Miguel
| |