lkml.org 
[lkml]   [2019]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] net: sctp: Rename fallthrough label to unhandled
    On Sat, Oct 05, 2019 at 09:46:41AM -0700, Joe Perches wrote:
    > fallthrough may become a pseudo reserved keyword so this only use of
    > fallthrough is better renamed to allow it.
    >
    > Signed-off-by: Joe Perches <joe@perches.com>
    > ---
    > net/sctp/sm_make_chunk.c | 12 ++++++------
    > 1 file changed, 6 insertions(+), 6 deletions(-)
    >
    > diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
    > index e41ed2e0ae7d..48d63956a68c 100644
    > --- a/net/sctp/sm_make_chunk.c
    > +++ b/net/sctp/sm_make_chunk.c
    > @@ -2155,7 +2155,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net,
    > case SCTP_PARAM_SET_PRIMARY:
    > if (ep->asconf_enable)
    > break;
    > - goto fallthrough;
    > + goto unhandled;
    >
    > case SCTP_PARAM_HOST_NAME_ADDRESS:
    > /* Tell the peer, we won't support this param. */
    > @@ -2166,11 +2166,11 @@ static enum sctp_ierror sctp_verify_param(struct net *net,
    > case SCTP_PARAM_FWD_TSN_SUPPORT:
    > if (ep->prsctp_enable)
    > break;
    > - goto fallthrough;
    > + goto unhandled;
    >
    > case SCTP_PARAM_RANDOM:
    > if (!ep->auth_enable)
    > - goto fallthrough;
    > + goto unhandled;
    >
    > /* SCTP-AUTH: Secion 6.1
    > * If the random number is not 32 byte long the association
    > @@ -2187,7 +2187,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net,
    >
    > case SCTP_PARAM_CHUNKS:
    > if (!ep->auth_enable)
    > - goto fallthrough;
    > + goto unhandled;
    >
    > /* SCTP-AUTH: Section 3.2
    > * The CHUNKS parameter MUST be included once in the INIT or
    > @@ -2203,7 +2203,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net,
    >
    > case SCTP_PARAM_HMAC_ALGO:
    > if (!ep->auth_enable)
    > - goto fallthrough;
    > + goto unhandled;
    >
    > hmacs = (struct sctp_hmac_algo_param *)param.p;
    > n_elt = (ntohs(param.p->length) -
    > @@ -2226,7 +2226,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net,
    > retval = SCTP_IERROR_ABORT;
    > }
    > break;
    > -fallthrough:
    > +unhandled:
    > default:
    > pr_debug("%s: unrecognized param:%d for chunk:%d\n",
    > __func__, ntohs(param.p->type), cid);
    > --
    > 2.15.0
    >
    >
    I'm still not a fan of the pseudo keyword fallthrough, but I don't have
    a problem in renaming the label, so

    Acked-by: Neil Horman <nhorman@tuxdriver.com>

    \
     
     \ /
      Last update: 2019-10-11 14:22    [W:2.594 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site