| From | Robert Jarzmik <> | Subject | Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table | Date | Wed, 30 Oct 2019 22:10:48 +0100 |
| |
Arnd Bergmann <arnd@arndb.de> writes:
> The driver should not require a machine specific header. Change > it to pass the gpio line through a lookup table, and move the > timing generator definitions into the drivers itself. > > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > I'm not overly confident that I got the correct device names > for the lookup table, it would be good if someone could > double-check. Ah the I2C and SPI devices querrying GPIOs ... unless someone does an actual test, this will probably be very regression prone ...
Anyway : Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
-- Robert
|