| From | Robert Jarzmik <> | Subject | Re: [PATCH 36/46] ARM: pxa: move smemc register access from clk to platform | Date | Wed, 30 Oct 2019 21:57:15 +0100 |
| |
Arnd Bergmann <arnd@arndb.de> writes:
> The get_sdram_rows() and get_memclkdiv() helpers need smemc > register that are separate from the clk registers, move > them out of the clk driver, and use an extern declaration > instead. > > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> This patch bothers me a bit.
The idea behind generic.c is that it's a file common to all pxa2xx, pxa3xx platforms. Yet with this patch, someone without history will believe that calling pxa_smemc_get_sdram_rows() on a pxa3xx platform is perfectly valid, while it is not, because DRAC2 doesn't exist on pxa3xx (bits are not defined in MDCNFG).
At least I'll rename the function to pxa2xx_smemc_get_sdram_rows() if you don't have a better idea.
Cheers.
-- Robert
|