Messages in this thread Patch in this message | | | From | zhong jiang <> | Subject | [PATCH v3 2/2] fault-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops | Date | Thu, 31 Oct 2019 09:56:17 +0800 |
| |
It is more clearly to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file operation rather than DEFINE_SIMPLE_ATTRIBUTE.
Meanwhile, debugfs_create_file() in debugfs_create_stacktrace_depth() can be replaced by debugfs_create_file_unsafe().
Suggested-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- lib/fault-inject.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 430b3ac..2655bfd 100644 --- a/lib/fault-inject.c +++ b/lib/fault-inject.c @@ -167,14 +167,14 @@ static int debugfs_ul_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get, - debugfs_stacktrace_depth_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get, + debugfs_stacktrace_depth_set, "%llu\n"); static void debugfs_create_stacktrace_depth(const char *name, umode_t mode, struct dentry *parent, unsigned long *value) { - debugfs_create_file(name, mode, parent, value, &fops_stacktrace_depth); + debugfs_create_file_unsafe(name, mode, parent, value, &fops_stacktrace_depth); } #endif /* CONFIG_FAULT_INJECTION_STACKTRACE_FILTER */ -- 1.7.12.4
| |