Messages in this thread Patch in this message | | | From | zhong jiang <> | Subject | [PATCH v3 1/2] fault-inject: Use debugfs_create_ulong() instead of debugfs_create_ul() | Date | Thu, 31 Oct 2019 09:56:16 +0800 |
| |
debugfs_create_ulong() has implemented the function of debugfs_create_ul() in lib/fault-inject.c. hence we can replace it.
Suggested-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- lib/fault-inject.c | 39 ++++++++++++--------------------------- 1 file changed, 12 insertions(+), 27 deletions(-)
diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 8186ca8..430b3ac 100644 --- a/lib/fault-inject.c +++ b/lib/fault-inject.c @@ -151,10 +151,13 @@ bool should_fail(struct fault_attr *attr, ssize_t size) EXPORT_SYMBOL_GPL(should_fail); #ifdef CONFIG_FAULT_INJECTION_DEBUG_FS +#ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER -static int debugfs_ul_set(void *data, u64 val) +static int debugfs_stacktrace_depth_set(void *data, u64 val) { - *(unsigned long *)data = val; + *(unsigned long *)data = + min_t(unsigned long, val, MAX_STACK_TRACE_DEPTH); + return 0; } @@ -164,24 +167,6 @@ static int debugfs_ul_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n"); - -static void debugfs_create_ul(const char *name, umode_t mode, - struct dentry *parent, unsigned long *value) -{ - debugfs_create_file(name, mode, parent, value, &fops_ul); -} - -#ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER - -static int debugfs_stacktrace_depth_set(void *data, u64 val) -{ - *(unsigned long *)data = - min_t(unsigned long, val, MAX_STACK_TRACE_DEPTH); - - return 0; -} - DEFINE_SIMPLE_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get, debugfs_stacktrace_depth_set, "%llu\n"); @@ -204,11 +189,11 @@ struct dentry *fault_create_debugfs_attr(const char *name, if (IS_ERR(dir)) return dir; - debugfs_create_ul("probability", mode, dir, &attr->probability); - debugfs_create_ul("interval", mode, dir, &attr->interval); + debugfs_create_ulong("probability", mode, dir, &attr->probability); + debugfs_create_ulong("interval", mode, dir, &attr->interval); debugfs_create_atomic_t("times", mode, dir, &attr->times); debugfs_create_atomic_t("space", mode, dir, &attr->space); - debugfs_create_ul("verbose", mode, dir, &attr->verbose); + debugfs_create_ulong("verbose", mode, dir, &attr->verbose); debugfs_create_u32("verbose_ratelimit_interval_ms", mode, dir, &attr->ratelimit_state.interval); debugfs_create_u32("verbose_ratelimit_burst", mode, dir, @@ -218,10 +203,10 @@ struct dentry *fault_create_debugfs_attr(const char *name, #ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER debugfs_create_stacktrace_depth("stacktrace-depth", mode, dir, &attr->stacktrace_depth); - debugfs_create_ul("require-start", mode, dir, &attr->require_start); - debugfs_create_ul("require-end", mode, dir, &attr->require_end); - debugfs_create_ul("reject-start", mode, dir, &attr->reject_start); - debugfs_create_ul("reject-end", mode, dir, &attr->reject_end); + debugfs_create_ulong("require-start", mode, dir, &attr->require_start); + debugfs_create_ulong("require-end", mode, dir, &attr->require_end); + debugfs_create_ulong("reject-start", mode, dir, &attr->reject_start); + debugfs_create_ulong("reject-end", mode, dir, &attr->reject_end); #endif /* CONFIG_FAULT_INJECTION_STACKTRACE_FILTER */ attr->dname = dget(dir); -- 1.7.12.4
| |