Messages in this thread | | | From | Markus Elfring <> | Subject | drm/mcde: Reconsider duplicate statement in mcde_probe() | Date | Mon, 28 Oct 2019 18:00:04 +0100 |
| |
Hello,
I have taken another look also at the implementation of the function “mcde_probe”. Now I wonder why the statement “drm->dev_private = mcde;” was specified twice there. https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/mcde/mcde_drv.c#L339 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mcde/mcde_drv.c?id=0365fb6baeb1ebefbbdad9e3f48bab9b3ccb8df3#n339
How do you think about to delete one of them so that a duplicate assignment can be avoided?
Regards, Markus
| |