lkml.org 
[lkml]   [2019]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectdrm/mcde: Reconsider duplicate statement in mcde_probe()
Date
Hello,

I have taken another look also at the implementation of the function “mcde_probe”.
Now I wonder why the statement “drm->dev_private = mcde;” was specified twice there.
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/mcde/mcde_drv.c#L339
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mcde/mcde_drv.c?id=0365fb6baeb1ebefbbdad9e3f48bab9b3ccb8df3#n339

How do you think about to delete one of them so that a duplicate assignment
can be avoided?

Regards,
Markus

\
 
 \ /
  Last update: 2019-10-28 18:01    [W:0.031 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site