Messages in this thread Patch in this message | | | Date | Mon, 28 Oct 2019 01:56:33 -0500 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH net-next] net: aquantia: fix error handling in aq_nic_init |
| |
Fix currenty ignored returned error by properly error checking aq_phy_init().
Addresses-Coverity-ID: 1487376 ("Unused value") Fixes: dbcd6806af42 ("net: aquantia: add support for Phy access") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index 433adc099e44..1914aa0a19d0 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -341,7 +341,8 @@ int aq_nic_init(struct aq_nic_s *self) if (self->aq_nic_cfg.aq_hw_caps->media_type == AQ_HW_MEDIA_TYPE_TP) { self->aq_hw->phy_id = HW_ATL_PHY_ID_MAX; - err = aq_phy_init(self->aq_hw); + if (!aq_phy_init(self->aq_hw)) + goto err_exit; } for (i = 0U, aq_vec = self->aq_vec[0]; -- 2.23.0
| |