Messages in this thread Patch in this message | | | From | Jessica Yu <> | Subject | [PATCH 1/4] scripts/nsdeps: use $MODORDER to obtain correct modules.order path | Date | Mon, 28 Oct 2019 16:14:24 +0100 |
| |
The nsdeps script calls generate_deps() for every module in the modules.order file. It prepends $objtree to obtain the full path of the top-level modules.order file. This produces incorrect results when calling nsdeps for an external module, as only the ns dependencies for in-tree modules listed in $objtree/modules.order are generated rather than the ns dependencies for the external module. To fix this, just use the MODORDER variable provided by kbuild - it uses the correct path for the relevant modules.order file (either in-tree or the one produced by the external module build).
Signed-off-by: Jessica Yu <jeyu@kernel.org> ---
So, not being too familiar with kbuild, I am not sure if MODORDER was the appropriate kbuild variable to use, but I could not find anything else that gives us the modules.order path. Masahiro, please let me know if this is appropriate usage.
scripts/nsdeps | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/nsdeps b/scripts/nsdeps index dda6fbac016e..54d2ab8f9e5c 100644 --- a/scripts/nsdeps +++ b/scripts/nsdeps @@ -52,7 +52,7 @@ generate_deps() { done } -for f in `cat $objtree/modules.order`; do +for f in `cat $MODORDER`; do generate_deps $f done -- 2.16.4
| |