Messages in this thread | | | Date | Sun, 13 Oct 2019 00:26:45 +0300 | From | Ivan Khoronzhuk <> | Subject | Re: [PATCH v5 bpf-next 09/15] samples/bpf: use own flags but not HOSTCFLAGS |
| |
On Fri, Oct 11, 2019 at 02:16:05PM +0300, Sergei Shtylyov wrote: >On 10/11/2019 12:57 PM, Ivan Khoronzhuk wrote: > >>>> While compiling natively, the host's cflags and ldflags are equal to >>>> ones used from HOSTCFLAGS and HOSTLDFLAGS. When cross compiling it >>>> should have own, used for target arch. While verification, for arm, >>> >>> While verifying. >> While verification stage. > > While *in* verification stage, "while" doesn't combine with nouns w/o >a preposition.
Sergei, better add me in cc list when msg is to me I can miss it.
Regarding the language lesson, thanks, I will keep it in mind next time, but the issue is not rude, if it's an issue at all, so I better leave it as is, as not reasons to correct it w/o code changes and everyone is able to understand it.
> >>>> arm64 and x86_64 the following flags were used always: >>>> >>>> -Wall -O2 >>>> -fomit-frame-pointer >>>> -Wmissing-prototypes >>>> -Wstrict-prototypes >>>> >>>> So, add them as they were verified and used before adding >>>> Makefile.target and lets omit "-fomit-frame-pointer" as were proposed >>>> while review, as no sense in such optimization for samples. >>>> >>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> >>> [...] > >MBR, Sergei
-- Regards, Ivan Khoronzhuk
| |