Messages in this thread | | | Subject | Re: [PATCH v5 bpf-next 09/15] samples/bpf: use own flags but not HOSTCFLAGS | From | Sergei Shtylyov <> | Date | Fri, 11 Oct 2019 14:16:05 +0300 |
| |
On 10/11/2019 12:57 PM, Ivan Khoronzhuk wrote:
>>> While compiling natively, the host's cflags and ldflags are equal to >>> ones used from HOSTCFLAGS and HOSTLDFLAGS. When cross compiling it >>> should have own, used for target arch. While verification, for arm, >> >> While verifying. > While verification stage.
While *in* verification stage, "while" doesn't combine with nouns w/o a preposition.
>>> arm64 and x86_64 the following flags were used always: >>> >>> -Wall -O2 >>> -fomit-frame-pointer >>> -Wmissing-prototypes >>> -Wstrict-prototypes >>> >>> So, add them as they were verified and used before adding >>> Makefile.target and lets omit "-fomit-frame-pointer" as were proposed >>> while review, as no sense in such optimization for samples. >>> >>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> >> [...]
MBR, Sergei
| |