| Date | Fri, 11 Oct 2019 07:49:40 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH 11/19] EDAC: Remove misleading comment in struct edac_raw_error_desc |
| |
Em Thu, 10 Oct 2019 20:25:26 +0000 Robert Richter <rrichter@marvell.com> escreveu:
> There never has been such function edac_raw_error_desc_clean() and in > function ghes_edac_report_mem_error() the whole struct is zero'ed > including the string arrays. Remove that comment. > > Signed-off-by: Robert Richter <rrichter@marvell.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> --- > include/linux/edac.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/edac.h b/include/linux/edac.h > index 8e72222e50b0..4d9673954856 100644 > --- a/include/linux/edac.h > +++ b/include/linux/edac.h > @@ -458,15 +458,10 @@ struct errcount_attribute_data { > * @other_detail: other driver-specific detail about the error > */ > struct edac_raw_error_desc { > - /* > - * NOTE: everything before grain won't be cleaned by > - * edac_raw_error_desc_clean() > - */ > char location[LOCATION_SIZE]; > char label[(EDAC_MC_LABEL_LEN + 1 + sizeof(OTHER_LABEL)) * EDAC_MAX_LABELS]; > long grain; > > - /* the vars below and grain will be cleaned on every new error report */ > u16 error_count; > int top_layer; > int mid_layer;
Thanks, Mauro
|