Messages in this thread | | | From | Robert Richter <> | Subject | Re: [PATCH 02/19] EDAC: Remove EDAC_DIMM_OFF() macro | Date | Fri, 11 Oct 2019 11:36:13 +0000 |
| |
Thanks for review.
On 11.10.19 07:09:03, Mauro Carvalho Chehab wrote: > Em Thu, 10 Oct 2019 20:25:07 +0000 > Robert Richter <rrichter@marvell.com> escreveu: > > > The EDAC_DIMM_OFF() macro takes 5 arguments to get the DIMM's index. > > This can be much simplified now as the offset is already stored in > > struct dimm_info. Use it directly and completely remove the > > EDAC_DIMM_OFF() macro. > > Ah, now I understand why you added the dimm idx field. One more reason > why to split it on a separate patch (or perhaps merge it here).
Right, it needs to be part of the this patch.
-Robert
| |