Messages in this thread | | | Date | Fri, 11 Oct 2019 11:28:04 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH v9 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module |
| |
On Thu, 10 Oct 2019 19:37:15 +0300 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> On 10/10/2019 05:59 PM, Thomas Bogendoerfer wrote: > > + /* enable ethernet PHY on IP29 systemboard */ > > + pci_read_config_dword(dev, PCI_SUBSYSTEM_VENDOR_ID, &sid); > > + if (sid == ((PCI_VENDOR_ID_SGI << 16) | IOC3_SUBSYS_IP29_SYSBOARD)) > > I thought PCI was little endian, thuis vendor ID at offset 0 and device ID > at offset 2?
you are right. I already messed it up in pci-xtalk-bridge.c. As this is just a fake sub device id, there is no harm, but I'll fix it.
Thomas.
-- SUSE Software Solutions Germany GmbH HRB 247165 (AG München) Geschäftsführer: Felix Imendörffer
| |