Messages in this thread | | | Subject | Re: [PATCH 2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver | From | James Morse <> | Date | Wed, 9 Jan 2019 09:57:06 +0000 |
| |
Hi Greg,
On 01/08/2019 06:12 PM, gregkh@linuxfoundation.org wrote: > On Tue, Jan 08, 2019 at 05:57:24PM +0000, James Morse wrote: >>>> diff --git a/drivers/edac/cortex_a15_l2_async_edac.c b/drivers/edac/cortex_a15_l2_async_edac.c >>>> new file mode 100644 >>>> index 000000000000..26252568e961 >>>> --- /dev/null >>>> +++ b/drivers/edac/cortex_a15_l2_async_edac.c >>>> @@ -0,0 +1,134 @@ >>>> +// SPDX-License-Identifier: GPL-2.0 >>>> +/* >>>> + * Copyright (C) 2018 Nokia Corporation >> >> (boiler plate not needed with the SPDX header) > > Not true at all. Copyright is not the same thing as an SPDX license > identifier in any way, shape, or form. As-is, this is just fine.
This looks funny because I removed the GPL license text that was here, but left this comment when trimming the reply. I should have left a few lines of it for context.
(Originally: https://lore.kernel.org/lkml/20190108104204.GA14243@zn.tnic/T/#u)
Thanks,
James
| |