Messages in this thread Patch in this message | | | Date | Tue, 8 Jan 2019 19:12:06 +0100 | From | "" <> | Subject | Re: [PATCH 2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver |
| |
On Tue, Jan 08, 2019 at 05:57:24PM +0000, James Morse wrote: > >> diff --git a/drivers/edac/cortex_a15_l2_async_edac.c b/drivers/edac/cortex_a15_l2_async_edac.c > >> new file mode 100644 > >> index 000000000000..26252568e961 > >> --- /dev/null > >> +++ b/drivers/edac/cortex_a15_l2_async_edac.c > >> @@ -0,0 +1,134 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Copyright (C) 2018 Nokia Corporation > (boiler plate not needed with the SPDX header)
Not true at all. Copyright is not the same thing as an SPDX license identifier in any way, shape, or form. As-is, this is just fine.
Now I will not go into the issues where a "Copyright..." line really means nothing at all anymore, as lawyers like to cargo-cult worse than programmers do, so it's good to have those lines there just to make them happy :)
thanks,
greg k-h
| |