Messages in this thread Patch in this message | | | From | Daniel Drake <> | Subject | [PATCH] kaslr: fix incorrect i8254 outb parameters | Date | Mon, 7 Jan 2019 11:40:24 +0800 |
| |
The outb call takes parameters value and port, in that order. Fix the parameters used in the kalsr i8254 fallback code.
Signed-off-by: Daniel Drake <drake@endlessm.com> --- arch/x86/lib/kaslr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c index 79778ab200e4..a53665116458 100644 --- a/arch/x86/lib/kaslr.c +++ b/arch/x86/lib/kaslr.c @@ -36,8 +36,8 @@ static inline u16 i8254(void) u16 status, timer; do { - outb(I8254_PORT_CONTROL, - I8254_CMD_READBACK | I8254_SELECT_COUNTER0); + outb(I8254_CMD_READBACK | I8254_SELECT_COUNTER0, + I8254_PORT_CONTROL); status = inb(I8254_PORT_COUNTER0); timer = inb(I8254_PORT_COUNTER0); timer |= inb(I8254_PORT_COUNTER0) << 8; -- 2.19.1
| |