Messages in this thread | | | From | Tianyu Lan <> | Date | Thu, 31 Jan 2019 20:08:02 +0800 | Subject | Re: [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver |
| |
On Thu, Jan 31, 2019 at 7:59 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Thu, Jan 31, 2019 at 06:17:32PM +0800, lantianyu1986@gmail.com wrote: > > --- /dev/null > > +++ b/drivers/iommu/hyperv-iommu.c > > @@ -0,0 +1,189 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#define pr_fmt(fmt) "HYPERV-IR: " fmt > > Minor nit, you never do any pr_*() calls, so this isn't needed, right?
Yes, you are right. I will remove it. Sorry. I used pr_info() during development stage and removed them before sending patch out. Thanks.
> > > +static cpumask_t ioapic_max_cpumask = { CPU_BITS_NONE }; > > +struct irq_domain *ioapic_ir_domain; > > Global? Why?
It should be "static" here.
-- Best regards Tianyu Lan
| |