Messages in this thread | | | Date | Thu, 31 Jan 2019 12:59:44 +0100 | From | Greg KH <> | Subject | Re: [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver |
| |
On Thu, Jan 31, 2019 at 06:17:32PM +0800, lantianyu1986@gmail.com wrote: > --- /dev/null > +++ b/drivers/iommu/hyperv-iommu.c > @@ -0,0 +1,189 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#define pr_fmt(fmt) "HYPERV-IR: " fmt
Minor nit, you never do any pr_*() calls, so this isn't needed, right?
> +static cpumask_t ioapic_max_cpumask = { CPU_BITS_NONE }; > +struct irq_domain *ioapic_ir_domain;
Global? Why?
thanks,
greg k-h
| |