Messages in this thread | | | Subject | Re: [PATCH 3/3] PM / devfreq: fix mem leak in devfreq_add_device() | From | Chanwoo Choi <> | Date | Mon, 21 Jan 2019 10:42:00 +0900 |
| |
Hi,
On 19. 1. 20. 오전 1:04, Yangtao Li wrote: > 'devfreq' is malloced in devfreq_add_device() and should be freed in > the error handling cases, otherwise it will cause memory leak. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 923889229a0b..fe6c157cb7e0 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -651,7 +651,7 @@ struct devfreq *devfreq_add_device(struct device *dev, > mutex_unlock(&devfreq->lock); > err = set_freq_table(devfreq); > if (err < 0) > - goto err_out; > + goto err_dev; > mutex_lock(&devfreq->lock); > } > >
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
-- Best Regards, Chanwoo Choi Samsung Electronics
| |