Messages in this thread | | | Subject | RE: [PATCH 3/3] PM / devfreq: fix mem leak in devfreq_add_device() | From | MyungJoo Ham <> | Date | Mon, 21 Jan 2019 10:23:51 +0900 |
| |
>'devfreq' is malloced in devfreq_add_device() and should be freed in >the error handling cases, otherwise it will cause memory leak. > >Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>--- > drivers/devfreq/devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c >index 923889229a0b..fe6c157cb7e0 100644 >--- a/drivers/devfreq/devfreq.c >+++ b/drivers/devfreq/devfreq.c >@@ -651,7 +651,7 @@ struct devfreq *devfreq_add_device(struct device *dev, > mutex_unlock(&devfreq->lock); > err = set_freq_table(devfreq); > if (err < 0) >- goto err_out; >+ goto err_dev; > mutex_lock(&devfreq->lock); > } >
| |