Messages in this thread Patch in this message | | | From | Vadim Bendebury <> | Subject | [PATCH] checkpatch: allow reporting C99 style comments | Date | Wed, 9 Jan 2019 21:01:17 -0800 |
| |
Presently C99 style comments are removed unconditionally before actual patch validity check happens. This is a problem for some third party projects which use checkpatch.pl but do not allow C99 style comments.
This patch adds yet another variable, named C99_COMMENT_TOLERANCE. If it is included in the --ignore command line or config file options list, C99 comments in the patch are reported as errors.
Tested by processing a patch with a C99 style comment, it passes the check just fine unless '--ignore C99_COMMENT_TOLERANCE' is present in .checkpatch.conf.
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b737ca9d7204..c5fe10934080 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -61,7 +61,6 @@ my $codespellfile = "/usr/share/codespell/dictionary.txt"; my $conststructsfile = "$D/const_structs.checkpatch"; my $typedefsfile = ""; my $color = "auto"; -my $allow_c99_comments = 1; sub help { my ($exitcode) = @_; @@ -1250,6 +1249,8 @@ sub sanitise_line { my $off = 0; my $c; + my $allow_c99_comments = !defined $ignore_type{"C99_COMMENT_TOLERANCE"}; + # Always copy over the diff marker. $res = substr($line, 0, 1); -- 2.20.1.97.g81188d93c3-goog
| |