lkml.org 
[lkml]   [2018]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 3.16 52/63] xfs: validate cached inodes are free when allocated
On Sat, Sep 22, 2018 at 01:15:42AM +0100, Ben Hutchings wrote:
> 3.16.58-rc1 review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Dave Chinner <dchinner@redhat.com>
>
> commit afca6c5b2595fc44383919fba740c194b0b76aff upstream.
>
> A recent fuzzed filesystem image cached random dcache corruption
> when the reproducer was run. This often showed up as panics in
> lookup_slow() on a null inode->i_ops pointer when doing pathwalks.
.....
> [bwh: Backported to 3.16:
> - Look up mode in XFS inode, not VFS inode
> - Use positive error codes, and EIO instead of EFSCORRUPTED]

Again, why EIO?

And ....
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> fs/xfs/xfs_icache.c | 73 +++++++++++++++++++++++++++++----------------
> 1 file changed, 48 insertions(+), 25 deletions(-)
>
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -133,6 +133,46 @@ xfs_inode_free(
> }
>
> /*
> + * If we are allocating a new inode, then check what was returned is
> + * actually a free, empty inode. If we are not allocating an inode,
> + * then check we didn't find a free inode.
> + *
> + * Returns:
> + * 0 if the inode free state matches the lookup context
> + * ENOENT if the inode is free and we are not allocating
> + * EFSCORRUPTED if there is any state mismatch at all

You changed the code but not the comment.

Cheers,

Dave.
--
Dave Chinner
dchinner@redhat.com

\
 
 \ /
  Last update: 2018-09-22 07:28    [W:0.311 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site