Messages in this thread |  | | From | Brendan Higgins <> | Date | Fri, 21 Sep 2018 15:30:42 -0700 | Subject | Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors |
| |
On Fri, Sep 21, 2018 at 3:26 PM Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote: > <snip> > > > + if (base_clk_divisor > ASPEED_I2CD_TIME_BASE_DIVISOR_MASK) { > > + base_clk_divisor = ASPEED_I2CD_TIME_BASE_DIVISOR_MASK; > > + clk_low = clk_high_low_mask; > > + clk_high = clk_high_low_mask; > > + dev_err(dev, > > + "clamping clock divider: divider requested, %u, is greater than largest possible divider, %u.", > > Please put a newline character at the end of the string.
I always forget to do that. I wonder if anyone has considered adding a warning for this to checkpatch?
> > Thanks, > Jae > > [....]
|  |