Messages in this thread |  | | Subject | Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors | From | Joe Perches <> | Date | Sat, 22 Sep 2018 07:16:58 -0700 |
| |
On Fri, 2018-09-21 at 15:30 -0700, Brendan Higgins wrote: > On Fri, Sep 21, 2018 at 3:26 PM Jae Hyun Yoo [] > > > + dev_err(dev, > > > + "clamping clock divider: divider requested, %u, is greater than largest possible divider, %u.", > > > > Please put a newline character at the end of the string. > > I always forget to do that. I wonder if anyone has considered adding a > warning for this to checkpatch?
Yes, but it's not possible to know when there a pr_cont that follows so any checkpatch test would be a false positive generator too.
|  |