Messages in this thread | | | Date | Mon, 17 Sep 2018 20:12:56 -0700 | From | Stefan Agner <> | Subject | Re: [PATCH 1/2] Compiler Attributes: naked was fixed in gcc 4.6 |
| |
On 13.09.2018 16:59, Miguel Ojeda wrote: > Commit 9c695203a7dd ("compiler-gcc.h: gcc-4.5 needs noclone > and noinline on __naked functions") added noinline and noclone > as a workaround for a gcc 4.5 bug, which was resolved in 4.6.0. > > Since now the minimum gcc supported version is 4.6, > we can clean it up. > > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44290 > and https://godbolt.org/z/h6NMIL > > Cc: Stefan Agner <stefan@agner.ch> > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Cc: Eli Friedman <efriedma@codeaurora.org> > Cc: Christopher Li <sparse@chrisli.org> > Cc: Kees Cook <keescook@chromium.org> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: Joe Perches <joe@perches.com> > Cc: Dominique Martinet <asmadeus@codewreck.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: linux-sparse@vger.kernel.org > Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Reviewed-by: Stefan Agner <stefan@agner.ch>
-- Stefan
> --- > include/linux/compiler-gcc.h | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index 763bbad1e258..25d3dd6b2702 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -84,14 +84,8 @@ > * to trace naked functions because then mcount is called without > * stack and frame pointer being set up and there is no chance to > * restore the lr register to the value before mcount was called. > - * > - * The asm() bodies of naked functions often depend on standard calling > - * conventions, therefore they must be noinline and noclone. > - * > - * GCC 4.[56] currently fail to enforce this, so we must do so ourselves. > - * See GCC PR44290. > */ > -#define __naked __attribute__((naked)) noinline __noclone notrace > +#define __naked __attribute__((naked)) notrace > > #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
| |