lkml.org 
[lkml]   [2018]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] Compiler Attributes: naked was fixed in gcc 4.6
    Date
    Commit 9c695203a7dd ("compiler-gcc.h: gcc-4.5 needs noclone
    and noinline on __naked functions") added noinline and noclone
    as a workaround for a gcc 4.5 bug, which was resolved in 4.6.0.

    Since now the minimum gcc supported version is 4.6,
    we can clean it up.

    See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44290
    and https://godbolt.org/z/h6NMIL

    Cc: Stefan Agner <stefan@agner.ch>
    Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    Cc: Eli Friedman <efriedma@codeaurora.org>
    Cc: Christopher Li <sparse@chrisli.org>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
    Cc: Joe Perches <joe@perches.com>
    Cc: Dominique Martinet <asmadeus@codewreck.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: linux-sparse@vger.kernel.org
    Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
    ---
    include/linux/compiler-gcc.h | 8 +-------
    1 file changed, 1 insertion(+), 7 deletions(-)

    diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
    index 763bbad1e258..25d3dd6b2702 100644
    --- a/include/linux/compiler-gcc.h
    +++ b/include/linux/compiler-gcc.h
    @@ -84,14 +84,8 @@
    * to trace naked functions because then mcount is called without
    * stack and frame pointer being set up and there is no chance to
    * restore the lr register to the value before mcount was called.
    - *
    - * The asm() bodies of naked functions often depend on standard calling
    - * conventions, therefore they must be noinline and noclone.
    - *
    - * GCC 4.[56] currently fail to enforce this, so we must do so ourselves.
    - * See GCC PR44290.
    */
    -#define __naked __attribute__((naked)) noinline __noclone notrace
    +#define __naked __attribute__((naked)) notrace

    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)

    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-14 02:01    [W:5.154 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site