Messages in this thread | | | Date | Wed, 12 Sep 2018 08:02:24 +1000 | From | Dave Chinner <> | Subject | Re: [PATCH v3 1/4] fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb() |
| |
On Tue, Sep 11, 2018 at 03:18:23PM -0400, Waiman Long wrote: > The nr_dentry_unused per-cpu counter tracks dentries in both the > LRU lists and the shrink lists where the DCACHE_LRU_LIST bit is set. > The shrink_dcache_sb() function moves dentries from the LRU list to a > shrink list and subtracts the dentry count from nr_dentry_unused. This > is incorrect as the nr_dentry_unused count Will also be decremented in > shrink_dentry_list() via d_shrink_del(). To fix this double decrement, > the decrement in the shrink_dcache_sb() function is taken out. > > Fixes: 4e717f5c1083 ("list_lru: remove special case function list_lru_dispose_all." > > Signed-off-by: Waiman Long <longman@redhat.com>
Please add a stable tag for this.
Otherwise looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- Dave Chinner david@fromorbit.com
| |