Messages in this thread | | | Date | Wed, 12 Sep 2018 08:02:44 +1000 | From | Dave Chinner <> | Subject | Re: [PATCH v3 2/4] fs: Don't need to put list_lru into its own cacheline |
| |
On Tue, Sep 11, 2018 at 03:18:24PM -0400, Waiman Long wrote: > The list_lru structure is essentially just a pointer to a table of > per-node LRU lists. Even if CONFIG_MEMCG_KMEM is defined, the list > field is just used for LRU list registration and shrinker_id is set > at initialization. Those fields won't need to be touched that often. > > So there is no point to make the list_lru structures to sit in their > own cachelines. > > Signed-off-by: Waiman Long <longman@redhat.com>
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com> -- Dave Chinner david@fromorbit.com
| |