Messages in this thread | | | Date | Mon, 10 Sep 2018 16:49:54 +0300 | From | Heikki Krogerus <> | Subject | Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree |
| |
Hi Angus,
On Mon, Sep 10, 2018 at 07:11:43AM -0600, Angus Ainslie wrote: > They are tcpm specific but need to go into the connector sub-node to get > parsed correctly. Would something like below be better ? > > diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt > b/Documentation/devicetree/bindings/usb/typec-tcpci.txt > index 0dd1469e7318..ae0a3e97d9b6 100644 > --- a/Documentation/devicetree/bindings/usb/typec-tcpci.txt > +++ b/Documentation/devicetree/bindings/usb/typec-tcpci.txt > @@ -15,6 +15,12 @@ Required sub-node: > of connector node are specified in > Documentation/devicetree/bindings/connector/usb-connector.txt > > +Optional properties for usb-c-connector sub-node: > +- init-vbus-source: set the initalization value for vbus-source to true. > + If this property is not present the initial value will be false. > +- init-vbus-charge: set the initalization value for vbus-charge to true. > + If this property is not present the initial value will be false.
In that file those are fine.
I would prefer init-vbus-sink over init-vbus-charge, but it's up to you.
Thanks,
-- heikki
| |