Messages in this thread | | | Subject | Re: [PATCH] remoteproc: q6v5: Add support to vote for rpmh power domains | From | Rajendra Nayak <> | Date | Mon, 6 Aug 2018 09:08:00 +0530 |
| |
On 8/3/2018 3:40 PM, Ulf Hansson wrote: > On 29 June 2018 at 12:20, Rajendra Nayak <rnayak@codeaurora.org> wrote: >> With rpmh ARC resources being modelled as power domains with >> performance state, add support to proxy vote on these for SDM845. >> Add support to vote on multiple of them, now that genpd supports >> associating multiple power domains to a device. >> >> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> >> --- >> This patch is dependent on the rpmh powerdomain driver >> still under review, >> https://lkml.org/lkml/2018/6/27/7 > > I assume you intend to re-spin this to use the new > dev_pm_domain_attach_by_name(), once 4.19 rc1 is out, right!? > > Anyway, please keep me in the loop.
Yes, I do plan to respin this one with the new api.
> > [...] > >> + if (num_pds > 1) { >> + for (i = 0; i < num_pds; i++) { >> + devs[i] = genpd_dev_pm_attach_by_id(dev, i); > > This API is supposed to be called only by the driver core. Please use > dev_pm_domain_attach_by_id|name() instead.
thanks, will change.
regards, Rajendra > > [...] > > Kind regards > Uffe >
| |